Opened 4 years ago
Closed 4 years ago
#24465 closed enhancement (fixed)
Let the completion functor prints the precision
Reported by:  vdelecroix  Owned by:  

Priority:  major  Milestone:  sage8.2 
Component:  categories  Keywords:  
Cc:  tscrim  Merged in:  
Authors:  Vincent Delecroix  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  c474002 (Commits, GitHub, GitLab)  Commit:  c474002aa02c8826c347653abf3328987856d9f1 
Dependencies:  Stopgaps: 
Description
sage: RR.construction() (Completion[+Infinity], Rational Field)
will become
sage: RR.construction() (Completion[+Infinity, prec=53], Rational Field)
Change History (9)
comment:1 Changed 4 years ago by
 Branch set to u/vdelecroix/24465
 Commit set to 5fbafc6852c9cf927f070d4e5e7180735acf9325
 Status changed from new to needs_review
comment:2 Changed 4 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
LGTM.
comment:4 Changed 4 years ago by
 Commit changed from 5fbafc6852c9cf927f070d4e5e7180735acf9325 to c474002aa02c8826c347653abf3328987856d9f1
Branch pushed to git repo; I updated commit sha1. New commits:
c474002  24465: fix doctest

comment:5 Changed 4 years ago by
 Status changed from needs_work to needs_review
Let the patchbot pass first.
comment:6 Changed 4 years ago by
 Status changed from needs_review to positive_review
Patchbot (morally) comes back clean.
comment:7 Changed 4 years ago by
 Status changed from positive_review to needs_work
File "src/doc/en/reference/coercion/index.rst", line 627, in doc.en.reference.coercion.index Failed example: sage.categories.pushout.construction_tower(Frac(CDF['x'])) Expected: [(None, Fraction Field of Univariate Polynomial Ring in x over Complex Double Field), (FractionField, Univariate Polynomial Ring in x over Complex Double Field), (Poly[x], Complex Double Field), (AlgebraicClosureFunctor, Real Double Field), (Completion[+Infinity], Rational Field), (FractionField, Integer Ring)] Got: [(None, Fraction Field of Univariate Polynomial Ring in x over Complex Double Field), (FractionField, Univariate Polynomial Ring in x over Complex Double Field), (Poly[x], Complex Double Field), (AlgebraicClosureFunctor, Real Double Field), (Completion[+Infinity, prec=53], Rational Field), (FractionField, Integer Ring)] ********************************************************************** 1 item had failures: 1 of 99 in doc.en.reference.coercion.index [84 tests, 1 failure, 3.38 s]
comment:8 Changed 4 years ago by
 Status changed from needs_work to positive_review
It looks like this does not have c474002
. Can you give it another go Volker?
comment:9 Changed 4 years ago by
 Branch changed from u/vdelecroix/24465 to c474002aa02c8826c347653abf3328987856d9f1
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
24456: let completion functor prints precision